goldyard/CLIProxyAPIPlus
1
0
Fork 0
mirror of https://github.com/githubhjs/CLIProxyAPIPlus.git synced 2026-07-13 18:15:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: extract setKiroIncognitoMode helper to reduce code duplication

Browse Source 
- Added setKiroIncognitoMode() helper function to handle Kiro auth incognito mode setting
- Replaced 3 duplicate code blocks (21 lines) with single function calls (3 lines)
- Kiro auth defaults to incognito mode for multi-account support
- Users can override with --incognito or --no-incognito flags

This addresses the code duplication noted in PR #1 review.
This commit is contained in:
Mansi
2025-12-05 23:06:07 +03:00
parent 02d8a1cfec
commit 9583f6b1c5
1 changed files with 16 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/server/main.go
+16 -21
View File
@@ -47,6 +47,19 @@ func init() {
buildinfo.BuildDate = BuildDate buildinfo.BuildDate = BuildDate
} }
// setKiroIncognitoMode sets the incognito browser mode for Kiro authentication.
// Kiro defaults to incognito mode for multi-account support.
// Users can explicitly override with --incognito or --no-incognito flags.
func setKiroIncognitoMode(cfg *config.Config, useIncognito, noIncognito bool) {
if useIncognito {
cfg.IncognitoBrowser = true
} else if noIncognito {
cfg.IncognitoBrowser = false
} else {
cfg.IncognitoBrowser = true // Kiro default
}
}
// main is the entry point of the application. // main is the entry point of the application.
// It parses command-line flags, loads configuration, and starts the appropriate // It parses command-line flags, loads configuration, and starts the appropriate
// service based on the provided flags (login, codex-login, or server mode). // service based on the provided flags (login, codex-login, or server mode).
@@ -465,36 +478,18 @@ func main() {
// Users can explicitly override with --no-incognito // Users can explicitly override with --no-incognito
// Note: This config mutation is safe - auth commands exit after completion // Note: This config mutation is safe - auth commands exit after completion
// and don't share config with StartService (which is in the else branch) // and don't share config with StartService (which is in the else branch)
if useIncognito { setKiroIncognitoMode(cfg, useIncognito, noIncognito)
cfg.IncognitoBrowser = true
} else if noIncognito {
cfg.IncognitoBrowser = false
} else {
cfg.IncognitoBrowser = true // Kiro default
}
cmd.DoKiroLogin(cfg, options) cmd.DoKiroLogin(cfg, options)
} else if kiroGoogleLogin { } else if kiroGoogleLogin {
// For Kiro auth, default to incognito mode for multi-account support // For Kiro auth, default to incognito mode for multi-account support
// Users can explicitly override with --no-incognito // Users can explicitly override with --no-incognito
// Note: This config mutation is safe - auth commands exit after completion // Note: This config mutation is safe - auth commands exit after completion
if useIncognito { setKiroIncognitoMode(cfg, useIncognito, noIncognito)
cfg.IncognitoBrowser = true
} else if noIncognito {
cfg.IncognitoBrowser = false
} else {
cfg.IncognitoBrowser = true // Kiro default
}
cmd.DoKiroGoogleLogin(cfg, options) cmd.DoKiroGoogleLogin(cfg, options)
} else if kiroAWSLogin { } else if kiroAWSLogin {
// For Kiro auth, default to incognito mode for multi-account support // For Kiro auth, default to incognito mode for multi-account support
// Users can explicitly override with --no-incognito // Users can explicitly override with --no-incognito
if useIncognito { setKiroIncognitoMode(cfg, useIncognito, noIncognito)
cfg.IncognitoBrowser = true
} else if noIncognito {
cfg.IncognitoBrowser = false
} else {
cfg.IncognitoBrowser = true // Kiro default
}
cmd.DoKiroAWSLogin(cfg, options) cmd.DoKiroAWSLogin(cfg, options)
} else if kiroImport { } else if kiroImport {
cmd.DoKiroImport(cfg, options) cmd.DoKiroImport(cfg, options)